=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/organisationunit/OrganisationUnitService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/organisationunit/OrganisationUnitService.java 2011-03-17 20:59:33 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/organisationunit/OrganisationUnitService.java 2011-04-22 17:45:58 +0000 @@ -249,15 +249,6 @@ */ Collection getOrganisationUnitsByNameAndGroups( String name, Collection groups, OrganisationUnit parent, boolean limit ); - /** - * Get the units in tree by the collection of given roots - * - * @param rootUnits the collection of given roots. - * @param unitsInTheTree the units in tree. - */ - void getUnitsInTheTree( Collection rootUnits, Set unitsInTheTree ); - - // ------------------------------------------------------------------------- // OrganisationUnitHierarchy // ------------------------------------------------------------------------- === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/organisationunit/DefaultOrganisationUnitService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/organisationunit/DefaultOrganisationUnitService.java 2011-04-19 14:37:25 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/organisationunit/DefaultOrganisationUnitService.java 2011-04-22 17:45:58 +0000 @@ -583,16 +583,6 @@ } @Override - public void getUnitsInTheTree( Collection rootUnits, Set unitsInTheTree ) - { - for ( OrganisationUnit root : rootUnits ) - { - unitsInTheTree.add( root ); - getUnitsInTheTree( root.getChildren(), unitsInTheTree ); - } - } - - @Override public int getMaxOfOrganisationUnitLevels() { return organisationUnitStore.getMaxOfOrganisationUnitLevels(); === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml' --- dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml 2011-04-22 17:02:27 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml 2011-04-22 17:45:58 +0000 @@ -22,7 +22,7 @@ - === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/DefineDataSetAssociationsAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/DefineDataSetAssociationsAction.java 2011-04-22 17:02:27 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/DefineDataSetAssociationsAction.java 2011-04-22 17:45:58 +0000 @@ -27,14 +27,8 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.Collection; -import java.util.HashSet; -import java.util.Set; - import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; -import org.hisp.dhis.organisationunit.OrganisationUnit; -import org.hisp.dhis.organisationunit.OrganisationUnitService; import org.hisp.dhis.oust.manager.SelectionTreeManager; import com.opensymphony.xwork2.Action; @@ -66,13 +60,6 @@ this.dataSetService = dataSetService; } - private OrganisationUnitService organisationUnitService; - - public void setOrganisationUnitService( OrganisationUnitService organisationUnitService ) - { - this.organisationUnitService = organisationUnitService; - } - // ------------------------------------------------------------------------- // Input & Output // ------------------------------------------------------------------------- @@ -91,26 +78,11 @@ public String execute() throws Exception { - - Collection rootUnits = selectionTreeManager.getRootOrganisationUnits(); - - Set unitsInTheTree = new HashSet(); - - organisationUnitService.getUnitsInTheTree( rootUnits, unitsInTheTree ); - DataSet dataSet = dataSetService.getDataSet( dataSetId ); - Set assignedSources = dataSet.getSources(); - - assignedSources.removeAll( organisationUnitService.convert( unitsInTheTree ) ); - - Collection selectedOrganisationUnits = selectionTreeManager - .getReloadedSelectedOrganisationUnits(); - - assignedSources.addAll( selectedOrganisationUnits ); - - dataSet.setSources( assignedSources ); - + dataSet.getSources().clear(); + dataSet.getSources().addAll( selectionTreeManager.getReloadedSelectedOrganisationUnits() ); + dataSetService.updateDataSet( dataSet ); return SUCCESS; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/META-INF/dhis/beans.xml' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/META-INF/dhis/beans.xml 2011-04-01 08:26:08 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/META-INF/dhis/beans.xml 2011-04-22 17:45:58 +0000 @@ -163,9 +163,6 @@ - - -